feat: dedockerize nodes #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at/dedockerize-node
…at/dedockerize-node
Terraform Feature Environment (dev-319)Terraform Initialization ⚙️
|
|
Nice! Any reason to invoke the binary instead of just spawning a thread that use mpc code directly? |
|
@itegulov mainly because we can then control the profile of the binary. Like, if we were to run integration tests as-is, it would use a singular performance profile depending on what we invoked the integration tests with |
ChaoticTempest
force-pushed
the
phuong/feat/dedockerize-node
branch
from
a14ea70 to
8ca535a
Compare
|
I have pushed a commit into your branch that makes this setup work on my Linux machine. For some reason spawned processes treat |
itegulov
approved these changes
Oct 16, 2023
|
Also, this takes <60 seconds to run all of the integration tests on my machine which is awesome |
Closed
volovyks
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Nice work @ChaoticTempest ! This change should make our development iterations faster and allow FE Integration tests to be built easily.
…covery into phuong/feat/dedockerize-node
Terraform Feature Environment Destroy (dev-319)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dedockerizes leader and signer nodes for local testing. Allows for incremental compilation without having to wait on docker builds.
New steps to run tests:
cargo build --release RUST_LOG=info cargo test -p mpc-recovery-integration-testsSetup all nodes:
output: