Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relayer hack deleted #347

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Relayer hack deleted #347

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 1 addition & 26 deletions mpc-recovery/src/leader_node/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use crate::msg::{
SignRequest, SignResponse, UserCredentialsRequest, UserCredentialsResponse,
};
use crate::oauth::verify_oidc_token;
use crate::relayer::msg::{CreateAccountAtomicRequest, RegisterAccountRequest};
use crate::relayer::msg::CreateAccountAtomicRequest;
use crate::relayer::NearRpcAndRelayerClient;
use crate::transaction::{
get_mpc_signature, new_create_account_delegate_action, sign_payload_with_mpc,
Expand All @@ -29,7 +29,6 @@ use axum_extra::extract::WithRejection;
use borsh::BorshDeserialize;
use curv::elliptic::curves::{Ed25519, Point};
use prometheus::{Encoder, TextEncoder};
use rand::{distributions::Alphanumeric, Rng};

use near_fetch::signer::KeyRotatingSigner;
use near_primitives::delegate_action::{DelegateAction, NonDelegateAction};
Expand All @@ -46,7 +45,6 @@ pub struct Config {
pub sign_nodes: Vec<String>,
pub near_rpc: String,
pub near_root_account: String,
pub account_creator_id: AccountId,
// TODO: temporary solution
pub account_creator_signer: KeyRotatingSigner,
pub partners: PartnerList,
Expand All @@ -60,7 +58,6 @@ pub async fn run(config: Config) {
sign_nodes,
near_rpc,
near_root_account,
account_creator_id,
account_creator_signer,
partners,
jwt_signature_pk_url,
Expand All @@ -69,28 +66,6 @@ pub async fn run(config: Config) {
tracing::debug!(?sign_nodes, "running a leader node");

let client = NearRpcAndRelayerClient::connect(&near_rpc);
// FIXME: Internal account id is retrieved from the ID token. We don't have a token for ourselves,
// but are still forced to allocate allowance.
// Using randomly generated internal account id ensures the uniqueness of user idenrifier on the relayer side so
// we can update the allowance on each server run.
for partner in partners.entries.iter() {
let fake_internal_account_id: String = rand::thread_rng()
.sample_iter(&Alphanumeric)
.take(16)
.map(char::from)
.collect();
client
.register_account_and_allowance(
RegisterAccountRequest {
account_id: account_creator_id.clone(),
allowance: 18_000_000_000_000_000_000, // should be enough to create 700_000+ accs
oauth_token: fake_internal_account_id,
},
partner.relayer.clone(),
)
.await
.unwrap();
}

let state = Arc::new(LeaderState {
env,
Expand Down
2 changes: 0 additions & 2 deletions mpc-recovery/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,6 @@ pub async fn run(cmd: Cli) -> anyhow::Result<()> {
sign_nodes,
near_rpc,
near_root_account,
// TODO: Create such an account for testnet and mainnet in a secure way
account_creator_id,
account_creator_signer,
partners,
jwt_signature_pk_url,
Expand Down
Loading