-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Added queue for sending encrypted messages #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I might be misunderstanding the code, but wouldn't it just crash after the first failed send?
@itegulov in the top level |
previous comment wasn't entirely correct. If failed in the top level section, the state won't be saved, so the failures would indeed abort. Recent commit directly handles the failed sending of encrypted messages at the call site instead |
Terraform Feature Environment (dev-395)Terraform Initialization ⚙️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Terraform Feature Environment Destroy (dev-395)Terraform Initialization ⚙️
|
No description provided.