-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
differentiate the logging messages #422
Conversation
Terraform Feature Environment (dev-422)Terraform Initialization ⚙️
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It's better to use spans: https://docs.rs/tracing/latest/tracing/ |
We can do this as a followup, or better enforce a consistent tracing style in our code by first changing all logging to the desired style. |
Terraform Feature Environment Destroy (dev-422)Terraform Initialization ⚙️
|
in node/src/protocol/consensus.rs and node/src/protocol/cryptography.rs
I basically added NodeState(ProtocolState) to the start of each message.