restore triple/presignature generation condition and optimize triple persistence #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Feb 19, 2024
Terraform Feature Environment (dev-466)Terraform Initialization ⚙️
|
Terraform Feature Environment Destroy (dev-466)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.1) check that during triple generation, triple persistence work as expected
4.2) check that during triple deletion, e.g. take_two(), triple persistence work as expected. There's an edge case where it could happen that one triple is deleted from datastore but not removed locally in take_two(), this should not cause correctness issue because repeatedly deleting triples from datastore won't err out.