-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5x faster unit test compilation on nix dev env #467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both on a warm cache running the command: time cargo test test_pk_recovery Before: cargo test test_pk_recovery 635.13s user 26.51s system 679% cpu 1:37.38 total After: cargo test test_pk_recovery 45.39s user 11.66s system 280% cpu 20.361 total I should probably find out why our compile cache keeps getting invalidated, but this is a quick win. Cost is this adds in a new native dependency.
DavidM-D
changed the title
5x faster unit test compilation
5x faster unit test compilation on nix dev env
Feb 20, 2024
volovyks
approved these changes
Feb 20, 2024
Terraform Feature Environment Destroy (dev-467)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both on a warm cache:
Before:
cargo test test_pk_recovery 635.13s user 26.51s system 679% cpu 1:37.38 total
After:
cargo test test_pk_recovery 45.39s user 11.66s system 280% cpu 20.361 total
I should probably find out why our compile cache keeps getting invalidated, but this is a quick win. Cost is this adds in a new native dependency.