Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed spurious recompile on integration tests #468

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Removed spurious recompile on integration tests #468

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f22739
Removed spurious recompile on integration tests
DavidM-D Feb 23, 2024
3de8ea1
Added comments
DavidM-D Feb 23, 2024
18e391b
Removed dep
DavidM-D Feb 23, 2024
69c07bf
Cargo fmt
DavidM-D Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions integration-tests/src/mpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
use std::path::{Path, PathBuf};
use std::{path::{Path, PathBuf}, fs};

use anyhow::Context;
use async_process::{Child, Command, ExitStatus, Stdio};
Expand Down Expand Up @@ -44,7 +44,21 @@ async fn build_package(
package: &str,
target: Option<&str>,
) -> anyhow::Result<ExitStatus> {
let mut cmd = Command::new("cargo");
// Do you have direnv installed?
let has_direnv = Command::new("which")
.arg("direnv")
.output()
.await
.expect("Failed to execute which command")
.status.success();

let mut cmd = if has_direnv {
// If so use the same compiler you always use
Command::new("direnv exec cargo")
} else {
// Otherwise give up and face the pain of constant recompilation
Command::new("cargo")
};
cmd.arg("build")
.arg("--package")
.arg(package)
Expand Down
Loading