Request counter #531
Merged
Request counter #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppca
reviewed
Mar 26, 2024
| @@ -49,7 +49,8 @@ pub enum ProtocolContractState { | |||
| #[derive(BorshDeserialize, BorshSerialize, PanicOnDefault)] | |||
| pub struct MpcContract { | |||
| protocol_state: ProtocolContractState, | |||
| pending_requests: TreeMap<[u8; 32], Option<(String, String)>>, | |||
| pending_requests: LookupMap<[u8; 32], Option<(String, String)>>, | |||
| request_counter: u32, | |||
There was a problem hiding this comment.
this will break contract I'm guessing? since when it was initialzed it did not have this field.
There was a problem hiding this comment.
It depends on how borsh deserialization works, I have not tested it. I belive it should be initialized on the first sign call.
There was a problem hiding this comment.
here's an example of how we can migrate state: https://github.com/near/near-sdk-rs/blob/1408127feefb37e7f84eba25984af18af46cd91d/examples/test-contract/src/lib.rs#L20
There was a problem hiding this comment.
so we need a new function similar to clean but ignores the state
There was a problem hiding this comment.
Let me try deploying an old contract and then redeploy to this one to see if it works
There was a problem hiding this comment.
yep. I got this error ```
kind: {
ExecutionError: 'Smart contract panicked: panicked at /Users/xiangyiz/.cargo/registry/src/index.crates.io-6f17d22bba15001f/near-sdk-5.0.0-alpha.2/src/environment/env.rs:921:46:\n' +
'Cannot deserialize the contract state.: Custom { kind: InvalidData, error: "Unexpected length of input" }'
},
There was a problem hiding this comment.
k, migration function deleted
Terraform Feature Environment (dev-531)Terraform Initialization ⚙️
|
ppca
approved these changes
Mar 28, 2024
ChaoticTempest
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
We should move to versioned contracts so this process is a lot easier: #545
Terraform Feature Environment Destroy (dev-531)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.