chore: Added /msg_multi for sending multiple messages & metrics for protocol loop iter latency #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-538)Terraform Initialization ⚙️
|
ChaoticTempest
force-pushed
the
phuong/chore/protocol-latency-metrics
branch
from
6d384a4 to
57ce65e
Compare
ChaoticTempest
changed the title
volovyks
reviewed
Mar 28, 2024
| @@ -86,7 +87,35 @@ async fn msg( | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[derive(Serialize, Deserialize)] | |||
| #[tracing::instrument(level = "debug", skip_all)] | |||
| async fn msg_multi( | |||
There was a problem hiding this comment.
Should we merge msg and msg_multi into one function?
|
I think the send_multi seems broken given an earlier deploy on dev last night, no triples were generated. Let's not merge this until we test it on dev again. |
|
yeah let me fix this on dev. Not necessary to go to partners just yet since what we have is working just fine |
|
closing this in favor of #549 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.