Subaccounts for load tests #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform Feature Environment (dev-552)Terraform Initialization ⚙️
|
|
Did you follow all the rules for creating a Top level account? You could just use |
Comment on lines
+40
to
+46
| let root_account = Account::from_secret_key( | ||
| near_workspaces::types::AccountId::try_from("dev-1660670387515-45063246810397".to_string()).unwrap(), | ||
| near_workspaces::types::SecretKey::from_str( | ||
| "ed25519:4hc3qA3nTE8M63DB8jEZx9ZbHVUPdkMjUAoa11m4xtET7F6w4bk51TwQ3RzEcFhBtXvF6NYzFdiJduaGdJUvynAi" | ||
| ).unwrap(), | ||
| &worker | ||
| ); |
There was a problem hiding this comment.
the issue with this is that somebody can easily disrupt the load test by getting this key. We wouldn't notice this either until we run it locally manually. We should be creating a dev account each time and delete the account at the end of the test
There was a problem hiding this comment.
Yep, I know. But dev_create_account does not work for me. And there is no Error handling. Maybe the faucet is broken.
There was a problem hiding this comment.
Tested, near-cli can create accounts using the faucet. Helper and URL parameters looks the same for me.
|
@ChaoticTempest what kind of rules? Here is what I'm doing: let worker = near_workspaces::testnet().await.unwrap();
let w_account = worker.dev_create_account().await.expect("Failed to create account");
tracing::info!("Created worker account: {}", w_account.id());It's not throwing any errors, but the account is never created on testnet. |
|
@ChaoticTempest looks like subaccounts is a way to go for now: near/near-workspaces-rs#354 |
|
@volovyks I see, alright let's at least delete the subaccount at the end of the test just so our main account doesn't bleed too much funds creating these accounts |
|
@ChaoticTempest added delete account step |
ChaoticTempest
approved these changes
Apr 11, 2024
ppca
approved these changes
Apr 11, 2024
Terraform Feature Environment Destroy (dev-552)Terraform Initialization ⚙️
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChaoticTempest I was not able to use Workspaces
create_tlaon testnet. But the subaccount approach works just fine.