Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix terraform code for getting sign_sk #607

Merged
merged 2 commits into from
May 23, 2024
Merged

fix terraform code for getting sign_sk #607

merged 2 commits into from
May 23, 2024

Conversation

ppca
Copy link
Contributor

@ppca ppca commented May 22, 2024

No description provided.

@ppca ppca requested a review from ChaoticTempest May 22, 2024 07:20
@ppca ppca requested a review from kmaus-near May 22, 2024 08:54
volovyks
volovyks approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
let's change it back after it is released on all current envs

@ppca ppca merged commit 480feea into develop May 23, 2024
2 of 3 checks passed
@ppca ppca deleted the xiangyi/fix_terraform branch May 23, 2024 02:19
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-607)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ppca, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volovyks volovyks volovyks approved these changes

@ChaoticTempest ChaoticTempest Awaiting requested review from ChaoticTempest

@kmaus-near kmaus-near Awaiting requested review from kmaus-near

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppca @volovyks