chore(refactor): restructure project + upgrade dependencies/transitive-dependencies #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
force-pushed
the
phuong/chore/upgrade-deps
branch
from
1203979 to
4499b8f
Compare
|
nevermind about rust-analyzer not working in root folder. Got it to work by including |
|
Audits will also continue to fail since I haven't completely upgraded everything yet. That will be left for the next PR |
ppca
previously approved these changes
May 26, 2024
| .await | ||
| .unwrap(); | ||
| .map_err(|err| { | ||
| tracing::error!(?err, "failed to join the participant set"); |
| @@ -43,7 +44,7 @@ jobs: | |||
| - name: Pull Relayer & Sandbox Docker Images | |||
| run: | | |||
| docker pull ghcr.io/near/os-relayer:12ba6e35690df3979fce0b36a41d0ca0db9c0ab4 | |||
| docker pull ghcr.io/near/near-lake-indexer:e6519c922435f3d18b5f2ddac5d1ec171ef4dd6b | |||
| docker pull ghcr.io/near/near-lake-indexer:node-1.38 | |||
There was a problem hiding this comment.
because node-1.39 doesn't work well with near-crypto 0.21. I'll update to near-crypto 0.22 afterwards which does. Just didn't want to add more complexity to this PR
volovyks
approved these changes
May 27, 2024
Terraform Feature Environment Destroy (dev-614)Terraform Initialization ⚙️
|
DavidM-D
pushed a commit
that referenced
this pull request
Jul 18, 2024
…e-dependencies (#614) * Utilize near_account_id crate * Getting local deps to work with tests * Moved out chain-signatures integration tests into own package * Seperated fastauth integration tests into own directory * Fixing configs and GH actions workflows * Proper lake-indexer image and more reliable builds * No more local packages * Some doc fixes and workflow fixes * Added secret manager accounts artifacts to .gitignore * Make tests work again * Get rust-analyzer to work on project root * Fix test-oidc image build * Try and fix audit CI * Clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades all our near related dependencies to
0.21to resolve security vulnerabilities. The project was restructured to facilitate this due to the fastauth project being in conflict with these dependencies. This is how our folder structure looks like now:Further restructuring will happen after this PR merges due to potential merge conflicts:
Note that we no longer have a top-level
Cargo.toml, which means we can no longer use thecargocommand at the root of the project. We'll need tocddirectly into the folder to use the command,and also watch out potentially for rust-analyzer since it won't be watching our project anymore at the root.This also reduces our build times now since we have two distinct projects when going to run tests instead of compiling everything in
integration-tests.Nix might also be failing since I didn't test that 🤷