Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has been broken since we change folder structure. already tested on develop this works.
This will fix the down dev env.
There were 2 bugs with the Dockerfile.multichain:
chain-signatures/
folder. the issue there is the top level mpc folder has noCargo.toml
file, nothing will be built;../target
, instead oftarget
. But later when we doCOPY --from=builder /usr/src/app/target/release/mpc-recovery-node /usr/local/bin/mpc-recovery-node
it is copying from
target
instead of../target
. Which will copy nothingThis can be verified by built artifact size. If you look at artifacts size: correct ones are 60+mb, incorrect ones are only 50+ mb. I think reflects the fact that actually nothing is built.
Also included a dependency fix. Because the dmd/bump-dependencies branch has been deleted, I updated to a commit hash that merged.