Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added nightly test that runs at 3:00 every day #676

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

ChaoticTempest
Copy link
Member

This adds a new nightly GH actions test that schedules a run at 3:00 am every single day. It utilizes an 8 node setup that will produce 100 signatures. The amount of signatures produced is low for now to test it out the nightly run.

GH actions might not be able to handle the 8 node setup, so will backpedal to 5 or something lower if needed later.


for _ in 0..SIGNATURE_AMOUNT {
wait_for::has_at_least_mine_presignatures(&ctx, 3).await?;
actions::single_signature_production(&ctx, &state_0).await?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not await but collect no. of success and no. of failures (& reason)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I'll add error logs to this

ailisp
ailisp previously approved these changes Jul 10, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's establish what we want to achieve with this test. It is still synthetic because we await triples before each signature request. Even if we remove those checks, we will still execute them one by one.

In real life, requests come in batches without knowledge about our system state. That is why I advocate using existing load tests. We can create any scenarios by modifying a simple config file and observing statistics in the end (if we save it somewhere or log it at the end of the test).

@ChaoticTempest
Copy link
Member Author

Will add something more akin to load tests to these nightlies in the future. Adding this as purely setup for now

@ChaoticTempest ChaoticTempest merged commit 8f43683 into develop Jul 16, 2024
3 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/feat/nightly-test branch July 16, 2024 23:01
Copy link

Terraform Feature Environment Destroy (dev-676)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants