Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should not check if caller of "respond" is a participant #694

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

volovyks
Copy link
Collaborator

We should not check if the caller of the “respond” function is a participant.
We agreed that we would use a locked contract and move from v1.mpc.near to v2.mpc.near in case of an upgrade. We plan to index both v1 and v2, but the participant list will be updated only on the latest contract.

I do not see any security risks in this, since we are checking that the provided signature is valid.

@volovyks volovyks linked an issue Jul 18, 2024 that may be closed by this pull request
@ChaoticTempest ChaoticTempest merged commit ee0d132 into develop Jul 19, 2024
4 checks passed
@ChaoticTempest ChaoticTempest deleted the serhii/remove-participant-check-comment branch July 19, 2024 06:29
Copy link

Terraform Feature Environment Destroy (dev-694)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KS–PCS–F–3 Missing Check Caller is a Participant
2 participants