Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: mainnet test deploy #712

Merged
merged 20 commits into from
Jul 24, 2024
Merged

FEAT: mainnet test deploy #712

merged 20 commits into from
Jul 24, 2024

Conversation

kmaus-near
Copy link
Collaborator

This PR also contains the proposed partner mainnet TF code, please spend some time to review and ask questions on anything.

kmaus-near and others added 15 commits May 30, 2024 09:32
@kmaus-near
Rename infra directories, and add documentation on deployment steps
8d4ddd8
@kmaus-near
updated docs
77a1baa
@kmaus-near
Merge branch 'develop' into kmaus-near/deployment-docs
b8743ff
@kmaus-near
Merge branch 'develop' of https://github.com/near/mpc-recovery into k…
42af48a 
…maus-near/deployment-docs
@ppca
add script to generate sign_sk
9b4bca2
@kmaus-near
initial deployment of mainnet nodes
654bb04
@kmaus-near
Merge branch 'xiangyi/add_script_for_sign_sk' of https://github.com/n…
8fd513c 
…ear/mpc-recovery into kmaus-near/mainnet-test-deploy
@kmaus-near
currently deployed mainnet resources
42a7b0a
@kmaus-near
added dev designator and perminant IPs to vars
8d04cdb
@kmaus-near
moved VMs to dev project
3a2aea4
@kmaus-near
misconfig changes
c3daf19
@kmaus-near
Fixed LB routing issue
2a8f76e
@kmaus-near
added partner code and currently deployed mainnet dev env
e21f4cc
@kmaus-near
added helper script to upload secrets to SM
bd7a2e6
@kmaus-near
added an example secrets file
af0b1c6
@kmaus-near kmaus-near requested a review from ppca July 23, 2024 19:02
@kmaus-near kmaus-near self-assigned this Jul 23, 2024
ppca
ppca reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ppca ppca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not the latest develop branch?

infra/partner-mainnet/main.tf Outdated Show resolved Hide resolved
infra/partner-mainnet/variables.tf Outdated Show resolved Hide resolved
infra/partner-mainnet/variables.tf Outdated Show resolved Hide resolved
infra/partner-mainnet/variables.tf Outdated Show resolved Hide resolved
infra/partner-mainnet/variables.tf
},
{
name = "MPC_RECOVERY_CONTRACT_ID"
value = "v2.multichain-mpc.testnet"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will need to change too

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are still waiting on naming this contract no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes.

infra/partner-mainnet/variables.tf Outdated Show resolved Hide resolved
infra/partner-mainnet/variables.tf Outdated Show resolved Hide resolved
infra/partner-testnet/network.tf Outdated Show resolved Hide resolved
infra/scripts/generate_cipher_and_sign_keys/Cargo.toml Outdated Show resolved Hide resolved
infra/scripts/generate_cipher_and_sign_keys/src/main.rs Outdated Show resolved Hide resolved
ppca
ppca reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ppca ppca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is there no infra/partner-multichain/variables.tf like all the other directories nvm

@kmaus-near kmaus-near requested a review from anshal-savla July 23, 2024 19:25
ppca
ppca reviewed Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ppca ppca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think directory infra/scripts/generate_cipher_and_sign_keys need to be deleted.

ppca
ppca reviewed Jul 23, 2024
View reviewed changes
infra/partner-mainnet/scripts/example.txt Outdated Show resolved Hide resolved
infra/partner-mainnet/scripts/example.txt Outdated
multichain-account-sk-mainnet-0=foo
multichain-cipher-sk-mainnet-0=bar
multichain-sign-sk-mainnet-0=baz
multichain-sk-share-mainnet-0=qux
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's do multichain-sk-share-mainnet-0=1 here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have this as an example, ideally this file will get deleted after they are uploaded to SM and we have everything working.

ppca
ppca reviewed Jul 23, 2024
View reviewed changes
infra/partner-mainnet/scripts/example.txt Outdated
@@ -0,0 +1,4 @@
multichain-account-sk-mainnet-0=foo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also will this have any danger of including \n or space? in the secret?

Copy link
Collaborator Author

@kmaus-near kmaus-near Jul 23, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I accounted for that in the script itself, so as long as they follow this format ("secret-name"="sec-val" ) it will work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice!

ppca
ppca previously approved these changes Jul 23, 2024
View reviewed changes
@kmaus-near
Copy link
Collaborator Author

Closes #678

@kmaus-near kmaus-near merged commit c0abf1d into develop Jul 24, 2024
2 checks passed
@kmaus-near kmaus-near deleted the kmaus-near/mainnet-test-deploy branch July 24, 2024 17:50
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-712)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @kmaus-near, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppca ppca ppca approved these changes

@anshal-savla anshal-savla Awaiting requested review from anshal-savla

Assignees

@kmaus-near kmaus-near

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kmaus-near @ppca @anshal-savla