Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make polling config less frequent #760

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

ChaoticTempest
Copy link
Member

This makes polling config less frequent as configs very rarely change if ever for now.

This updates the poll time from 1 second to 5 minutes

Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. One problem to keep in mind is the configuration difference between node could exist for up to 5 minutes. As my understanding current protocol config different won't cause problem, but future added could be, and please double think of current protocol config as well in case there is problematic config that I'm not aware of.

Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can lead to inconsistencies. But that is nothing compared to the manual update.

@volovyks volovyks merged commit 401ba83 into develop Jul 30, 2024
3 checks passed
@volovyks volovyks deleted the phuong/fix/make-polling-config-less-freq branch July 30, 2024 10:25
Copy link

Terraform Feature Environment Destroy (dev-760)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @volovyks, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants