Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load test fixes #765

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Load test fixes #765

merged 6 commits into from
Jul 30, 2024

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Jul 30, 2024 •
edited
Loading

@ppca Fixed acc name and log string. We need to deploy this code to our test envs to make it work. Overall load tests were functioning, I've added a few comments for better understanding. The error rate is over the roof because our dev env is malfunctioning.

@volovyks volovyks requested a review from ppca July 30, 2024 11:08
@volovyks volovyks linked an issue Jul 30, 2024 that may be closed by this pull request
Load tests not working for multichain contract #659
Closed
@volovyks volovyks changed the title update acc for load tests Load test fixes Jul 30, 2024
volovyks
volovyks commented Jul 30, 2024
View reviewed changes
chain-signatures/contract/src/lib.rs
@@ -728,7 +728,10 @@ impl VersionedMpcContract {
) -> Result<SignatureResponse, MpcContractError> {
match self {
Self::V0(_) => match signature {
SignatureResult::Ok(signature) => Ok(signature),
SignatureResult::Ok(signature) => {
log!("Signature is ready.");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this log to appear in sign() call logs

@ppca ppca merged commit 3d280d1 into develop Jul 30, 2024
5 checks passed
@ppca ppca deleted the serhii/load-test-acc branch July 30, 2024 17:25
@github-actions GitHub Actions
Copy link

Terraform Feature Environment Destroy (dev-765)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan 


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ppca, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppca ppca ppca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load tests not working for multichain contract
2 participants
@volovyks @ppca