Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make manager reject messages for already completed sigs #773

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

ChaoticTempest
Copy link
Member

Noticed this wasn't handled quite yet. This would be the case where a node's indexer is behind but slowly catches up and tries to do signature request, but it has already been completed for other nodes

@ChaoticTempest ChaoticTempest requested review from volovyks and ppca July 30, 2024 19:55
ppca
ppca previously approved these changes Jul 30, 2024
@ChaoticTempest ChaoticTempest force-pushed the phuong/fix/signature-gc branch from 024a65d to 13b4d50 Compare July 30, 2024 20:20
@ChaoticTempest ChaoticTempest merged commit ae42c83 into develop Jul 30, 2024
3 of 4 checks passed
@ChaoticTempest ChaoticTempest deleted the phuong/fix/signature-gc branch July 30, 2024 22:40
Copy link

Terraform Feature Environment Destroy (dev-773)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ChaoticTempest, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants