Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: signature request order and retrying #779

Merged
merged 6 commits into from
Jul 31, 2024

Conversation

ChaoticTempest
Copy link
Member

This fixes:

  • signature retrying constantly even after request has fully timeout on contract. This adds in total generation timeout to alleviate that.
  • signature request ordering is very arbitrary. Could likely go into a case where we don't pick the signature request and it starves. This fixes that by adding insertion order into the requests as one of the metrics for choice.

@ChaoticTempest ChaoticTempest requested review from volovyks and ppca July 31, 2024 02:05
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ppca ppca merged commit dda2acc into develop Jul 31, 2024
4 checks passed
@ppca ppca deleted the phuong/fix/signature-request-fixes branch July 31, 2024 16:22
Copy link

Terraform Feature Environment Destroy (dev-779)

Terraform Initialization ⚙️success

Terraform Destroy success

Show Destroy Plan


No changes. No objects need to be destroyed.

Either you have not created any objects yet or the existing objects were
already deleted outside of Terraform.

Destroy complete! Resources: 0 destroyed.

Pusher: @ppca, Action: pull_request, Working Directory: ``, Workflow: Terraform Feature Env (Destroy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants