fix: give indexer some time to catch up before failing on restart #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Aug 2, 2024
| @@ -324,7 +328,7 @@ pub fn run( | |||
| anyhow::Ok(lake) | |||
| }) else { | |||
| tracing::error!(?options, "indexer failed to build"); | |||
| backoff(i); | |||
| backoff(i, 1, 120); | |||
There was a problem hiding this comment.
Seems i will never decrease, and eventually i will become max if indexer keep working. Do we need to restore it to a small number on a not failing case?
volovyks
reviewed
Aug 2, 2024
chain-signatures/contract/src/lib.rs
Outdated
| @@ -584,6 +584,7 @@ impl VersionedMpcContract { | |||
| #[near_bindgen] | |||
| impl VersionedMpcContract { | |||
| #[handle_result] | |||
| #[init(ignore_state)] | |||
There was a problem hiding this comment.
Why do we need this change? Not sure if it's safe.
There was a problem hiding this comment.
ah sorry. shouldn't have pushed this.
ppca
force-pushed
the
xiangyi/mainnet_sleep
branch
from
af90fba to
867eb20
Compare
ChaoticTempest
approved these changes
Aug 2, 2024
Comment on lines
+356
to
+359
| if i > 0 { | ||
| // give it some time to catch up | ||
| backoff(i, 10, 300); | ||
| } |
There was a problem hiding this comment.
we could've just had a flat sleep(5mins) here instead of modifying backoff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.