Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u128 -> U128 in experimental_signature_deposit #815

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

volovyks
Copy link
Collaborator

No description provided.

@volovyks volovyks linked an issue Aug 26, 2024 that may be closed by this pull request
Copy link

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@volovyks volovyks requested a review from ailisp August 26, 2024 11:43
ailisp
ailisp previously approved these changes Aug 27, 2024
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ailisp
Copy link
Member

ailisp commented Aug 27, 2024

test_experimental_signature_deposit needs to be fixed

@volovyks volovyks requested a review from ailisp August 27, 2024 12:14
@ailisp ailisp merged commit aa41ddf into develop Aug 28, 2024
4 checks passed
@ailisp ailisp deleted the serhii/fix-price-formatting branch August 28, 2024 00:57
@bh2smith
Copy link

Has this new contract been deployed to both mainnet and testnet?

@volovyks
Copy link
Collaborator Author

@bh2smith only to dev env v1.signer-dev.testnet.
v1.signer-prod.testnet and mainnet will be released with other features later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Near U128 instead of primitive u128
3 participants