Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas test #834

Merged
merged 1 commit into from
Sep 18, 2024
Merged

gas test #834

merged 1 commit into from
Sep 18, 2024

Conversation

volovyks
Copy link
Collaborator

No description provided.

@volovyks volovyks marked this pull request as ready for review September 10, 2024 16:26
@ailisp
Copy link
Member

ailisp commented Sep 10, 2024

Nice finding! I would also test using a maximum sized request

@volovyks
Copy link
Collaborator Author

@ailisp what do you mean by maximum sized request? Aren't they all the same size?

@ailisp
Copy link
Member

ailisp commented Sep 12, 2024

@volovyks i mean path. there was some clear_state_on_finish invoked by sign_helper spending around 6T gas while it usually spend 3T gas. Given the clear_state_on_finish is very simple, it maybe related to size of request

@volovyks
Copy link
Collaborator Author

@ailisp good point, I've checked, and path size does affect gas, but it is not significant for now.

@volovyks volovyks merged commit d604047 into develop Sep 18, 2024
3 of 4 checks passed
@volovyks volovyks deleted the serhii/gas-test branch September 18, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants