feat: add negative integration tests #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Apr 20, 2023
| mod key { | ||
| use rand::{distributions::Alphanumeric, Rng}; | ||
|
|
||
| pub fn random() -> String { |
There was a problem hiding this comment.
Let;s clarify that this is a sk. And I guess it's better to return it as a SecretKey type and stringify if needed.
There was a problem hiding this comment.
The reason why I went with strings everywhere is because I wanted to be uniform with malformed values (which are not representable with the strict SecretKey type).
| }) | ||
| .await?; | ||
| assert_eq!(status_code, 500); | ||
| assert!(matches!(new_acc_response, NewAccountResponse::Err { .. })); |
There was a problem hiding this comment.
Should we comapre the error message here? Check for actual erro type?
There was a problem hiding this comment.
We could yeah. I think generally parameterizing NewAccountResponse::Err with kind could be a good idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR streamlines writing integration tests and introduces a bunch of negative scenarios.