chore: Added retry logic #86
Conversation
ChaoticTempest
force-pushed
the
phuong/retry-logic
branch
2 times, most recently
from
7d18f2e to
f388415
Compare
ChaoticTempest
force-pushed
the
phuong/retry-logic
branch
from
f388415 to
d5ef08d
Compare
| state.account_creator_id.clone(), | ||
| state.account_creator_sk.clone(), | ||
| ); | ||
|
|
||
| state | ||
| .client | ||
| .register_account(RegisterAccountRequest { |
There was a problem hiding this comment.
Should this request be insode of the retry block?
There was a problem hiding this comment.
the retry logic is only meant for sending transactions. The register_account endpoint shouldn't be apart of it and if it fails, should just forward it to the user immediately I think. That's probably for the best UX right now, just so the user can retry themselves for now.
There was a problem hiding this comment.
Both calls are to the relayer, that is why I do not think that there is lot of differance. But it's not a blocker.
| // TODO: use NAR in the future. | ||
| //! Separated away from client to distinguish functions that are common and | ||
| //! need to be moved eventually into their own separate crate. Not necessarily | ||
| //! to be used from workspaces directly even though it is imported from there. |
There was a problem hiding this comment.
This is not workspaces anymore :)
Let's mention, that this is the code from workspaces and ideally it should be moved to a separate crate (some kind of near-api-rs) as one effort for workspaces and this project.
There was a problem hiding this comment.
yeah I mentioned it was imported from workspaces, and should eventually be moved to near-api-rs (NAR) when it gets created later
No description provided.