Feat: Add 12 Dev nodes/cleanup workflow files #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volovyks
approved these changes
Oct 7, 2024
| @@ -156,6 +156,7 @@ resource "google_compute_instance_template" "tpl" { | |||
|
|
|||
| lifecycle { | |||
| create_before_destroy = "true" | |||
| ignore_changes = [ disk[0].source_image, labels ] | |||
There was a problem hiding this comment.
What does this line mean?
There was a problem hiding this comment.
I think this likely ignores whether image changes or not, whenever you push, the nodes will be updated.
There was a problem hiding this comment.
Correct, this was to stop any unnecessary redeployments when adding nodes.
| @@ -1,42 +0,0 @@ | |||
| name: Multichain Contract | |||
There was a problem hiding this comment.
How do we deploy the contract now?
There was a problem hiding this comment.
By using deploy-multichain-dev-contract.yml, I don't think this workflow file is in use.
ppca
approved these changes
Oct 7, 2024
| @@ -156,6 +156,7 @@ resource "google_compute_instance_template" "tpl" { | |||
|
|
|||
| lifecycle { | |||
| create_before_destroy = "true" | |||
| ignore_changes = [ disk[0].source_image, labels ] | |||
There was a problem hiding this comment.
I think this likely ignores whether image changes or not, whenever you push, the nodes will be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things in this pull request, but should close #855 at least for Dev. Not sure if we will be running additional nodes ourselves or onboarding more partners, so we can leave that open if need be.
I also cleaned up and changed names of some of the Workflow files which would close #868. There is a roadmap for GitHub to release the ability to organize Workflows into folders, but it does not seem to be on their priority list for this year, so I think this is the best I can do as far as cleanup. I also set the Dev node deployment to be triggered manually, and it will restart the nodes each time, even if there are no changes. Let me know if there are any issues with what I've got.