Remove datastore, fetch latest block #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
volovyks
commented
Nov 7, 2024
•
volovyks
commented
- Remove DataStore and all related code
- Add Redis storage manager for persistent in app data (for now only latest processed block)
- Do not pass latest block in Terraform, we often forget to update those values, not a good practice
- Fetch latest block using RPC client and use it or use latest processed block (check the logic for more details)
…/mpc-recovery into serhii/presignature-storage
…overy into serhii/presignature-storage
auto-mausx
reviewed
Nov 8, 2024
auto-mausx
reviewed
Nov 8, 2024
auto-mausx
reviewed
Nov 8, 2024
|
@kmaus-near reverted changes in mpc recovery |
This was
linked to
issues
Nov 18, 2024
Closed
Comment on lines
+9
to
+10
| const APP_DATA_PREFIX: &str = "app_data"; | ||
| const APP_DATA_STORAGE_VERSION: &str = "v1"; |
There was a problem hiding this comment.
these configs should live in the contract config
There was a problem hiding this comment.
We should change them in case of a breaking change in storage. It may be useful for hotfixes, like resetting all triples, but I do not want to add it now.
ppca
reviewed
Nov 25, 2024
ppca
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
lgtm. Please wait for @ChaoticTempest 's review since he wrote a lot of the indexer logic.
|
@ppca I will merge it now, @ChaoticTempest saw it before and is having issues with his laptop. We must test how it affects our stability and speed before the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.