refactor(contract): address TS linter complaints

add stronger typing to `nameFunction`
near · Oct 7, 2020 · c3c69c3 · c3c69c3
1 parent eeb698a
commit c3c69c3
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/lib/contract.js b/lib/contract.js
diff --git a/src/contract.ts b/src/contract.ts
@@ -4,16 +4,16 @@ import { getTransactionLastResult } from './providers';
 import { PositionalArgsError, ArgumentTypeError } from './utils/errors';
 
 // Makes `function.name` return given name
-function nameFunction(name, body) {
+function nameFunction(name: string, body: (args?: any[]) => {}) {
     return {
-        [name](...args) {
+        [name](...args: any[]) {
             return body(...args);
         }
     }[name];
 }
 
 const isUint8Array = (x: any) =>
-    x.byteLength !== undefined && x.byteLength === x.length;
+    x && x.byteLength !== undefined && x.byteLength === x.length;
 
 const isObject = (x: any) =>
     Object.prototype.toString.call(x) === '[object Object]';

diff --git a/test/contract.test.js b/test/contract.test.js
@@ -49,6 +49,10 @@ const contract = new Contract(account, null, {
         test('throws PositionalArgsError if given too many arguments', () => {
             return expect(contract[method]({}, 1, 0, 'oops')).rejects.toBeInstanceOf(PositionalArgsError);
         });
+
+        test('allows args encoded as Uint8Array (for borsh)', async () => {
+            expect(await contract[method](new Uint8Array()));
+        });
     });
 });