refactor: replace ajv with is-my-json-valid

.changeset/weak-guests-dream.md

@@ -0,0 +1,6 @@
+---
+"@near-js/accounts": patch
+"near-api-js": patch
+---
+
+replace ajv with is-my-json-valid

packages/accounts/package.json

@@ -22,11 +22,10 @@
     "@near-js/transactions": "workspace:*",
     "@near-js/types": "workspace:*",
     "@near-js/utils": "workspace:*",
-    "ajv": "8.11.2",
-    "ajv-formats": "2.1.1",
     "bn.js": "5.2.1",
     "borsh": "1.0.0",
     "depd": "2.0.0",
+    "is-my-json-valid": "^2.20.6",
     "lru_map": "0.4.1",
     "near-abi": "0.1.1"
   },
@@ -36,9 +35,9 @@
     "bs58": "4.0.0",
     "jest": "26.0.1",
     "near-hello": "0.5.1",
+    "near-workspaces": "3.4.0",
     "ts-jest": "26.5.6",
-    "typescript": "4.9.4",
-    "near-workspaces": "3.4.0"
+    "typescript": "4.9.4"
   },
   "files": [
     "lib"

packages/accounts/src/contract.ts

@@ -1,16 +1,14 @@
 import { getTransactionLastResult, Logger } from '@near-js/utils';
 import { ArgumentTypeError, PositionalArgsError } from '@near-js/types';
 import { LocalViewExecution } from './local-view-execution';
-import Ajv from 'ajv';
-import addFormats from 'ajv-formats';
+import validator from 'is-my-json-valid'
 import BN from 'bn.js';
 import depd from 'depd';
 import { AbiFunction, AbiFunctionKind, AbiRoot, AbiSerializationType } from 'near-abi';
 
 import { Account } from './account';
 import { UnsupportedSerializationError, UnknownArgumentError, ArgumentSchemaError, ConflictingOptions } from './errors';
 
-
 // Makes `function.name` return given name
 function nameFunction(name: string, body: (args?: any[]) => any) {
     return {
@@ -20,7 +18,7 @@ function nameFunction(name: string, body: (args?: any[]) => any) {
     }[name];
 }
 
-function validateArguments(args: object, abiFunction: AbiFunction, ajv: Ajv, abiRoot: AbiRoot) {
+function validateArguments(args: object, abiFunction: AbiFunction, abiRoot: AbiRoot) {
     if (!isObject(args)) return;
 
     if (abiFunction.params && abiFunction.params.serialization_type !== AbiSerializationType.Json) {
@@ -36,8 +34,9 @@ function validateArguments(args: object, abiFunction: AbiFunction, ajv: Ajv, abi
         const arg = args[p.name];
         const typeSchema = p.type_schema;
         typeSchema.definitions = abiRoot.body.root_schema.definitions;
-        const validate = ajv.compile(typeSchema);
-        if (!validate(arg)) {
+        const validate = validator(typeSchema)
+        const valid = validate(arg)
+        if (!valid) {
             throw new ArgumentSchemaError(p.name, validate.errors);
         }
     }
@@ -50,22 +49,6 @@ function validateArguments(args: object, abiFunction: AbiFunction, ajv: Ajv, abi
     }
 }
 
-function createAjv() {
-    // Strict mode is disabled for now as it complains about unknown formats. We need to
-    // figure out if we want to support a fixed set of formats. `uint32` and `uint64`
-    // are added explicitly just to reduce the amount of warnings as these are very popular
-    // types.
-    const ajv = new Ajv({
-        strictSchema: false,
-        formats: {
-            uint32: true,
-            uint64: true
-        }
-    });
-    addFormats(ajv);
-    return ajv;
-}
-
 const isUint8Array = (x: any) =>
     x && x.byteLength !== undefined && x.byteLength === x.length;
 
@@ -171,7 +154,6 @@ export class Contract {
                 .map((methodAbi) => ({ name: methodAbi.name, abi: methodAbi }));
         }
 
-        const ajv = createAjv();
         viewMethodsWithAbi.forEach(({ name, abi }) => {
             Object.defineProperty(this, name, {
                 writable: false,
@@ -182,7 +164,7 @@ export class Contract {
                     }
 
                     if (abi) {
-                        validateArguments(args, abi, ajv, abiRoot);
+                        validateArguments(args, abi, abiRoot);
                     }
 
                     if (useLocalViewExecution) {
@@ -228,7 +210,7 @@ export class Contract {
                     }
 
                     if (abi) {
-                        validateArguments(args[0].args, abi, ajv, abiRoot);
+                        validateArguments(args[0].args, abi, abiRoot);
                     }
 
                     return this._changeMethod({ methodName: name, ...args[0] });

packages/accounts/src/errors.ts

@@ -1,4 +1,4 @@
-import { ErrorObject } from 'ajv';
+import { ValidationError } from 'is-my-json-valid';
 
 export class UnsupportedSerializationError extends Error {
     constructor(methodName: string, serializationType: string) {
@@ -13,7 +13,7 @@ export class UnknownArgumentError extends Error {
 }
 
 export class ArgumentSchemaError extends Error {
-    constructor(argName: string, errors: ErrorObject[]) {
+    constructor(argName: string, errors: ValidationError[]) {
         super(`Argument '${argName}' does not conform to the specified ABI schema: '${JSON.stringify(errors)}'`);
     }
 }

packages/near-api-js/package.json

@@ -22,8 +22,6 @@
         "@near-js/types": "workspace:*",
         "@near-js/utils": "workspace:*",
         "@near-js/wallet-account": "workspace:*",
-        "ajv": "8.11.2",
-        "ajv-formats": "2.1.1",
         "bn.js": "5.2.1",
         "borsh": "1.0.0",
         "depd": "2.0.0",