Naj 44 make sign and send transaction functionality public

[esaminu]

Motivation

NAJ-44

Description

Make Account.signAndSendTransaction public so transactions can be sent directly from Account instances

Checklist

• Read the contributing guidelines
• Commit messages follow the conventional commits spec
• Performed a self-review of the PR
• Added automated tests
• Manually tested the change

[changeset-bot]

🦋 Changeset detected

Latest commit: 330b2db

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
near-api-js	Major
@near-js/cookbook	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[andy-haynes]

NAJ-44 mentions

We cannot just remove the protected accessor because that would be a breaking change (every implementation of Account would have to update).

Is there more context to this on the original issue (I can't find the link)? I'm not seeing how this is a breaking change, assuming that "implementation of Account" refers to creating a subclass of it.

[esaminu]

@andy-haynes Yes it appears that's what the ticket is referring to. i.e. if you extend account you'd have to make this method public too as opposed to protected. There's a discussion this here as well: #557 (comment)

This is not an issue imo but we have to bump a major here (updating changeset)

[andy-haynes]

@andy-haynes Yes it appears that's what the ticket is referring to. i.e. if you extend account you'd have to make this method public too as opposed to protected. There's a discussion this here as well: #557 (comment)

This is not an issue imo but we have to bump a major here (updating changeset)

Sounds good, thanks!

[hcho112]

LGTM