fix: error types #1003
Merged
fix: error types #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 726b795 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
hcho112
previously approved these changes
Oct 2, 2022
Not sure, what do you think @esaminu ? |
|
@marcinbodnar imo this would be a patch version bump since it's a backward compatible fix |
marcinbodnar
force-pushed
the
NAJ-175-error-types-have-degraded
branch
from
c331912 to
47c2bf2
Compare
This was referenced Oct 10, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a partial restoration of changes from #910 . At this moment near-api-js is not returning proper error types for errors:
AccountDoesNotExist,AccessKeyDoesNotExist,CodeDoesNotExist,InvalidNonce. Issue: #980 .Description
getErrorTypeFromErrorMessagefunction, with a default value change. The previous implementation was always returningUntypedErrorif the error message doesn't match pointed strings, which means it could possibly change the type even if it already exists, which was not ideal - this function should return the proper type if it matches, and don't change the type if not matches. If the request doesn't have a type at all, we have a proper condition to change the type if it doesn't exist in theTypedErrorclass.getErrorTypeFromErrorMessageinJsonRpcProvider.querymethod, but with the current message.getErrorTypeFromErrorMessageinJsonRpcProvider.sendJsonRpcmethod.UntypedErrorcase from it.Checklist