-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace bn.js with BigInt #1223
Conversation
🦋 Changeset detectedLatest commit: f7c541e The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see all my comments above
How is that the tests are not catching problems here? for example, the change of BN(10).exp(24) to BigInt(10**24) should have broke a bunch of stuff (since it is in the utils.js module, that every other module uses). Wrongly changing it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks but looks very good
Hey @gagdiez , this PR is ready for review. Merging is blocked until you approve it because you requested changes. |
I am still puzzled about the tests, and why they didn't fail. Specially on the We need to find an explanation, and add more tests if necessary. If I am being picky with this PR is because a rounding error could lead to real people losing real money. |
@gtsonevv LGTM |
Delaying the merge of this PR intentionally, because we want to batch these breaking changes with other oustanding breaking changes, in order to not increment major versions unnecessarily. |
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
Reduce amount of dependencies.
Test Plan
Related issues/PRs
#1217
#1200