-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce methods to construct URLs to the wallet without instant redirect #1260
Conversation
…wallet sign tx page
🦋 Changeset detectedLatest commit: b78a324 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I'd just want the changeset to be changed from patch to minor in order to conform to semver. After that we can merge
done |
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
Some use cases certainly require not redirecting instantly to the Wallet page
The following methods were added to the WalletConnection class that construct URL without calling
window.assign
afterward:requestSignInUrl
requestSignTransactionsUrl
Test Plan
Related issues/PRs
Deprecated PR -> #1025
Issue -> #1010