Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce methods to construct URLs to the wallet without instant redirect #1260

Merged
merged 7 commits into from
Jan 23, 2024

Conversation

denbite
Copy link
Contributor

@denbite denbite commented Jan 14, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Some use cases certainly require not redirecting instantly to the Wallet page

The following methods were added to the WalletConnection class that construct URL without calling window.assign afterward:

  • requestSignInUrl
  • requestSignTransactionsUrl

Test Plan

Related issues/PRs

Deprecated PR -> #1025
Issue -> #1010

Copy link

changeset-bot bot commented Jan 14, 2024

🦋 Changeset detected

Latest commit: b78a324

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@near-js/wallet-account Minor
near-api-js Patch
@near-js/cookbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gtsonevv
gtsonevv previously approved these changes Jan 22, 2024
vikinatora
vikinatora previously approved these changes Jan 22, 2024
Copy link
Collaborator

@vikinatora vikinatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I'd just want the changeset to be changed from patch to minor in order to conform to semver. After that we can merge

.changeset/twelve-rabbits-cough.md Outdated Show resolved Hide resolved
@denbite denbite dismissed stale reviews from vikinatora and gtsonevv via 41b242d January 22, 2024 16:28
@denbite
Copy link
Contributor Author

denbite commented Jan 22, 2024

lgtm, I'd just want the changeset to be changed from patch to minor in order to conform to semver. After that we can merge

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants