Fix delegate schema #1314
Merged
Fix delegate schema #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current schema has two fields swapped (actions and nonce), which makes it impossible to create DelegateActions, since the borsh serialization ends up mixing the nonce with the action
🦋 Changeset detectedLatest commit: d3feb0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@gtsonevv can we get this released ASAP? People cannot create meta-transactions :/ |
4 tasks
frol
approved these changes
Mar 11, 2024
Merged
andy-haynes
pushed a commit
that referenced
this pull request
Aug 15, 2024
The current schema has two fields swapped (actions and nonce), which makes it impossible to create DelegateActions, since the borsh serialization ends up mixing the nonce with the action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
Currently people can create meta-transactions, but once they are relayed, the RPC answers
Parse error: Failed to decode transaction: Unexpected variant tag: 131. This is because the transaction is being wrongly serialized since two fields are swapped in the Schema.Test Plan
Added a test checking that the SCHEMA can deserialize a valid delegateAction, since the SCHEMA is the same for both serialization and deserialization, that should suffice
Related issues/PRs
#1313