-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
biometric-ed25519 update to support BitWarden password manager #1331
Conversation
🦋 Changeset detectedLatest commit: 30e3b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bd9a970
to
bc2e982
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I've left only a few minor styling and wording remarks
@vikinatora thank you for the review, updated PR as per request |
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
This PR contains fixes for #1330 issue. The main reason why passkey did not work with BitWarden was because they do not follow standard format for webauthn credentials in which they used data format of
Uint8Array
instead ofArrayBuffer
. However they can be easily convert-able so in this PR I have implemented logic to do the conversion.Test Plan
On https://github.com/near/fast-auth-signer/ repo, run it locally with commend
yarn && NETWORK_ID=testnet yarn run start --https
(Bitwarden only works with https)On new Chrome browser profile, install Bitwarden chrome extension package.
manually navigate to localhost:3000/create-account and try to create an account.
(At this point, you should be able to replicate the issues)
Apply the above change directly to source code. (There is issues with setting up yarn link/npm link between these two projects)
I have confirm that above change has resolved the issue and was able to conduct create key and get keys without error.