Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export encode transaction #1360

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Jul 11, 2024

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Test Plan

Related issues/PRs

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 3482dbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
near-api-js Patch
@near-js/cookbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@andy-haynes andy-haynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you please just revert the updates to workflows and the lockfile since they're not relevant to this change?

@gtsonevv
Copy link
Collaborator Author

@andy-haynes I will revert the workflow changes and open a separate PR for them. This will be necessary as pnpm/action-setup v2 is no longer supported and github actions fail.

@gtsonevv gtsonevv requested a review from andy-haynes July 12, 2024 07:56
@andy-haynes
Copy link
Collaborator

Thank you for the clarification @gtsonevv, apologies for the confusion. If you mention these kinds of things in the PR description it will be easier for me to know it was an intentional change 🙂

Can you please remove the lockfile changes from this PR? That's probably easier than rebasing on top of #1359 anyway

@andy-haynes
Copy link
Collaborator

@race-of-sloths 🦥

@race-of-sloths
Copy link

race-of-sloths commented Jul 12, 2024

@gtsonevv Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
You are true leader! Other sloths hot on your heels, keep moving!

Shows profile picture for the author of the PR

Current status: executed

@gtsonevv check out your results on the Race of Sloths Leaderboard! and in the profile

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@andy-haynes andy-haynes merged commit 430ebba into near:master Jul 15, 2024
1 check passed
@race-of-sloths
Copy link

🔄 The PR has been merged.

Important

This pull request is a part of the Race of Sloths and has not been scored yet. Scoring will close in 24 hours! 🕰️

@github-actions github-actions bot mentioned this pull request Jul 15, 2024
@race-of-sloths
Copy link

✅ PR is finalized!

Your contribution is much appreciated with a final score of 0!
You have received 0 Sloth points for this contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants