-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update RPC error schema for protocol version 69 #1363
Conversation
With protocol version 68, cross-shard congestion control is introduced that adds two new errors on the RPC endpoints for submitting transactions. (ShardCongested, ShardStuck) Protocol version 69 introduces stateless validation and also adds a new error for submitted transactions. (ReceiptSizeExceeded) Technically, there are additional errors in nearcore's version of the rpc schema. But those are from nightly features that have not been masked properly. (NonRefundableTransferToExistingAccount and InvalidTransactionVersion are waiting for NEP-491 and NEP-541 respectively.) Aside from updating the schema, I also added human readable error messages and tests for the new errors.
🦋 Changeset detectedLatest commit: 8584206 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I've only added a minor bump changeset for the utils package, since I only changed code in there. If this isn't right, please let me know which packages should be included. |
@race-of-sloths please, include my PR in the race |
@jakmeier Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
The average score is 3 @jakmeier check out your results on the Race of Sloths Leaderboard! and in the profile What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
@mpeterdev @andy-haynes can one of you please review this PR? Vlad pinged you in the Telegram Tools Communiy Group last weak but you might have missed that. |
Thanks @jakmeier for the clear description! Changeset looks good, much appreciated. |
@race-of-sloths score 3 |
🌟 Score recorded!@andy-haynes, thank you for scoring this pull request in the Race of Sloths! |
✅ PR is finalized!Your contribution is much appreciated with a final score of 3! Another weekly streak completed, well done @jakmeier! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths |
With protocol version 68, cross-shard congestion control is introduced that adds two new errors on the RPC endpoints for submitting transactions. (ShardCongested, ShardStuck)
Protocol version 69 introduces stateless validation and also adds a new error for submitted transactions. (ReceiptSizeExceeded)
Technically, there are additional errors in nearcore's version of the rpc schema. But those are from nightly features that have not been masked properly. (NonRefundableTransferToExistingAccount and InvalidTransactionVersion are waiting for NEP-491 and NEP-541 respectively.)
Aside from updating the schema, I also added human readable error messages and tests for the new errors.
Closes #1358
Pre-flight checklist
pnpm changeset
to create achangeset
JSON document appropriate for this change.Motivation
See #1358
Test Plan
Unit tests in
packages/utils/test/rpc-errors.test.js
check that the new error kinds are recognized as expected.Related issues/PRs
See #1358