Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse NEAR amount with commas #168

Merged
merged 2 commits into from
Jan 8, 2020
Merged

Parse NEAR amount with commas #168

merged 2 commits into from
Jan 8, 2020

Conversation

vgrichina
Copy link
Contributor

No description provided.

@vgrichina
Copy link
Contributor Author

@nearmax do you think we should just remove commas when parsing or actually validate?

@vgrichina
Copy link
Contributor Author

@nearmax friendly ping

MaksymZavershynskyi
MaksymZavershynskyi approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@MaksymZavershynskyi MaksymZavershynskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@vgrichina vgrichina merged commit 7780388 into master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaksymZavershynskyi MaksymZavershynskyi MaksymZavershynskyi approved these changes

@janedegtiareva janedegtiareva Awaiting requested review from janedegtiareva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vgrichina @MaksymZavershynskyi