Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rpc for light client proof #337

Merged
merged 9 commits into from
Jun 19, 2020
Merged

add rpc for light client proof #337

merged 9 commits into from
Jun 19, 2020

Conversation

bowenwang1996
Copy link
Contributor

Add experimental_lightClientProof to provider to support querying light client proofs, which is needed for the Eth <> NEAR bridge to work. It is hard to write a test now because the rpc is not yet supported on testnet.

@bowenwang1996 bowenwang1996 requested a review from vgrichina as a code owner June 9, 2020 01:34
@vgrichina
Copy link
Contributor

@bowenwang1996 check startFromVersion in test/account.test.js – should be possible to do the same for testing not released yet features

@bowenwang1996
Copy link
Contributor Author

@vgrichina that would be true if we have proper versioning.

@vgrichina
Copy link
Contributor

@vgrichina that would be true if we have proper versioning.

Then we need to fix versioning in nearcore. @chefsale we need to figure this out. It should be possible to gate tests to run only on newer version of nearcore and looks like according to @bowenwang1996 there is something missing on nearcore side of things.

@bowenwang1996
Copy link
Contributor Author

@vgrichina yes it is blocked partially on the devops side.

@bowenwang1996 bowenwang1996 requested a review from vgrichina June 16, 2020 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants