Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix adding app key to multisig account #449

Merged
merged 1 commit into from
Nov 8, 2020
Merged

Fix adding app key to multisig account #449

merged 1 commit into from
Nov 8, 2020

Conversation

vgrichina
Copy link
Contributor

No description provided.

@vgrichina vgrichina requested a review from mattlockyer November 7, 2020 11:20
@vgrichina vgrichina requested a review from chadoh as a code owner November 7, 2020 11:20
Copy link
Contributor

@mattlockyer mattlockyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I think this was in one of the other PRs we didn't have time to merge before token transfers were enabled.

I'll add to regression tests for account_multisig.test.js today.

@vgrichina
Copy link
Contributor Author

I think this was in one of the other PRs we didn't have time to merge before token transfers were enabled.

Which of them? This one https://github.com/near/near-api-js/pull/445/files doesn't seem to touch getKey method.

I'll add to regression tests for account_multisig.test.js today.

Yeah, I think we need to get full coverage for account_multisig.

Main problem I guess is that we didn't really use apps before Berry Club 🥑

@mattlockyer
Copy link
Contributor

Tested recoveryMethods in wallet linked to this branch. Looks like things are working.

The addKey override was likely left over from when everything was in wallet twoFactor.js.

Everything that's wallet specific, e.g. adding recovery methods, is handled now in wallet.js > addAccessKey but we may want to clean this up in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants