Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add v important "more" to error message #456

Merged
merged 1 commit into from
Nov 17, 2020

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Nov 17, 2020

"LackBalanceForState": "The account {{account_id}} wouldn't have enough balance to cover storage, required to have {{amount}} more"

This error gets thrown when you need amount MORE tokens. The amount passed in is not the total needed, it is the amount by which you are short. We need the "more"!!

Also, the RentUnpaid error is no longer thrown by nearcore (it was mostly removed in 050396a and fully removed in 2622b4f), so we can remove this error message.

@chadoh chadoh requested a review from frol November 17, 2020 19:21
    "LackBalanceForState": "The account {{account_id}} wouldn't have
    enough balance to cover storage, required to have {{amount}} more"

This error gets thrown when you need `amount` MORE tokens. The amount
passed in is not the total needed, it is the amount by which you are
short. We need the "more"!!

Also, the `RentUnpaid` error is no longer thrown by nearcore (it was
mostly removed in [050396a] and fully removed in [2622b4f]), so we can
remove this error message.

  [050396a]: near/nearcore@050396a
  [2622b4f]: near/nearcore@2622b4f
@chadoh chadoh force-pushed the fix/low-balance-for-state-error branch from 532d50a to 036cd72 Compare November 17, 2020 20:08
@chadoh chadoh merged commit 8807885 into master Nov 17, 2020
@chadoh chadoh deleted the fix/low-balance-for-state-error branch November 17, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants