New error handling design #507
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frol
reviewed
Mar 26, 2021
src/utils/rpc_errors.ts
Outdated
Comment on lines
21
to
23
| export class ServerErrorContext { | ||
| transactionHash?: string; | ||
| errorPath?: Record<string, any>; |
There was a problem hiding this comment.
transactionHash and errorPath are only relevant to the broadcast_* and tx (EXPERIMENTAL_tx_status) endpoints, so I would call it TransactionExecutionFailureContext, and make both of the fields required. I guess errorPath can be renamed to transactionExecutionError (it will have either ActionError or InvalidTxError)
|
I Will request feedback after these changes: #515 (comment) |
|
This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days. |
|
Update: Serhii will break out some code into separate PRs. |
|
This fix requires too many breaking changes that are hard to introduce properly. Some good parts will be cherry-picked in later PR's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
messageandtypebecame mandatory inTypedError. It should prevent us from creatingUntypedErrors, and errors without description in the future.errorPathadded to allServerErrros's as a part oferrorContext.ServerErrorsince it'sServerErrorspecific.Breaking Changes:
TypedError.messagebecame mandatory fieldTypedError.typebecame mandatory fieldTypedErrortoServerErrorX_ErrortoServerErrorTypedErroris exported as a part ofnear-api-jsinterface, but I don't think that it's intended to be used in other projects.