Changes to serialization + NEPs 5 & 8 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [AddKeyTransaction, 'addKey'], | ||
| [DeleteKeyTransaction, 'deleteKey'], | ||
| ]); | ||
| class Enum { |
There was a problem hiding this comment.
it's strange to have Enum under transaction. is there some other name that would work, or at least a comment on what this means?
| @@ -12,3 +13,216 @@ export function base_encode(value: Uint8Array | string): string { | |||
| export function base_decode(value: string): Uint8Array { | |||
| return bs58.decode(value); | |||
| } | |||
|
|
|||
| const INITIAL_LENGTH = 1024; | |||
There was a problem hiding this comment.
It would be helpful to have a comment here what this means, and what happens if the data is smaller than this value
| @@ -0,0 +1,41 @@ | |||
|
|
|||
There was a problem hiding this comment.
Are there deserialize tests too?
|
The pipeline is failing due to lint errors (most likely easy fix by npm run fix) and also tests are failing. test/serialize.test.js is actually failing -- is that because we don't have a node with the nearcore changes yet? |
janedegtiareva
approved these changes
Aug 17, 2019
src.ts/transaction.ts
Outdated
| [fieldName]: transaction, | ||
| }); | ||
| const SCHEMA = { | ||
| 'Signature': {kind: 'struct', fields: [['keyType', 'u8'], ['data', [32]]]}, |
There was a problem hiding this comment.
It would be very useful to document this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changes required for