Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add returnError to transaction options #704

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Conversation

willemneal
Copy link
Contributor

Currently this is the first part of #703.

@willemneal willemneal requested a review from vgrichina as a code owner October 1, 2021 15:37
@willemneal willemneal requested review from volovyks and chadoh October 1, 2021 15:38
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with the logic described in the issue. We will need to deprecate returnError = False with time.

@github-actions
Copy link
Contributor

This PR is stale because it has been open for 7 days with no activity. Remove stale label or comment or this will be closed in another 7 days.

@willemneal willemneal merged commit fd6d643 into master Oct 13, 2021
@willemneal willemneal deleted the feat/addReturnError branch October 13, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants