fix: add check to suppress retry log #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@volovyk-s Any thoughts? |
mpeterdev
reviewed
Nov 16, 2021
Comment on lines
+167
to
+168
| currentUrl.searchParams.delete('meta'); | ||
| currentUrl.searchParams.delete('transactionHashes'); |
There was a problem hiding this comment.
just double checking, is this change intentionally included in this PR? didn't see it mentioned in commit message or comments
There was a problem hiding this comment.
This is because the last PR didn't commit the JS artifacts. So this adds them, but generally you can ignore the JS files since they get built before a release anyway.
mpeterdev
approved these changes
Nov 16, 2021
|
@volovyk-s Any other blockers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when trying a transaction the warning can be ignore. It was very log and made the output of workspace tests very noisy.