Fix pending result for receipts #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgrichina
reviewed
Oct 1, 2019
| @@ -145,7 +145,7 @@ describe('with deploy contract', () => { | |||
| expect(logs.length).toBe(3); | |||
| expect(logs[0]).toEqual(`[${contractId}]: LOG: log before assert`); | |||
| expect(logs[1]).toMatch(new RegExp(`^\\[${contractId}\\]: ABORT: "expected to fail" filename: "assembly/main.ts" line: \\d+ col: \\d+$`)); | |||
| expect(logs[2]).toEqual(`[${contractId}]: Runtime error: wasm async call execution failed with error: WasmerCallError("Smart contract has explicitly invoked \`panic\`.")`); | |||
| // expect(logs[2]).toEqual(`[${contractId}]: Runtime error: wasm async call execution failed with error: WasmerCallError("Smart contract has explicitly invoked \`panic\`.")`); | |||
There was a problem hiding this comment.
That's @mikhailOK change to support new error format in staging, until we move towards proper error handling.
There was a problem hiding this comment.
@evgenykuzyakov @mikhailOK probably good idea to add TODO with GH issue / WIP PR link so it doesn't get lost
vgrichina
approved these changes
Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return status for legacy results.
Update Pending to Unknown (staging nearcore PR will change it).
Merge @mikhailOK staging change for staging support.