Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error handling done by staging #85

Merged
merged 4 commits into from
Oct 7, 2019
Merged

Update error handling done by staging #85

merged 4 commits into from
Oct 7, 2019

Conversation

evgenykuzyakov
Copy link
Contributor

Failure status now provides the error message and error type.
See nearcore change: near/nearcore#1408

@evgenykuzyakov
Copy link
Contributor Author

It passes all tests on new nearcore change as well.

This was referenced Oct 7, 2019
Merged
Merged
vgrichina
vgrichina approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@vgrichina vgrichina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's add TODOs and tracking bugs for legacy stuff that will be removed

@evgenykuzyakov
Copy link
Contributor Author

I actually not sure, we'd remove any legacy stuff. And when should we remove it. Will add a TODO for adapt... function.

@evgenykuzyakov evgenykuzyakov merged commit 2fcf22f into master Oct 7, 2019
@evgenykuzyakov evgenykuzyakov deleted the error-handling branch October 7, 2019 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgrichina vgrichina vgrichina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evgenykuzyakov @vgrichina