Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposed chunk RPC API (nearcore 0.4.2+) #88

Merged
merged 2 commits into from
Oct 30, 2019
Merged

Conversation

frol
Copy link
Collaborator

@frol frol commented Oct 22, 2019

@frol frol requested a review from vgrichina October 22, 2019 22:07
Copy link
Contributor

@vgrichina vgrichina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make sure CI passes

test/providers.test.js Outdated Show resolved Hide resolved
@frol
Copy link
Collaborator Author

frol commented Oct 22, 2019

@vgrichina I expect it will pass once nearcore is deployed with the PR, so in theory, we only need to run CI once more once that happens. I am just proactively creating PRs :)

@vgrichina
Copy link
Contributor

@vgrichina I expect it will pass once nearcore is deployed with the PR, so in theory, we only need to run CI once more once that happens. I am just proactively creating PRs :)

Do you plan to wait until it is deployed on master testnet or on staging? If you only want to wait for staging deploy (or not wait at all), then it's necessary to gate this test by nearcore version.

@frol
Copy link
Collaborator Author

frol commented Oct 23, 2019

I plan to wait for the API hit master. I hope it happens soon since without this API Explorer is useless (I cannot get a transactions list from nearcore otherwise).

@frol frol force-pushed the feature/chunk-rpc branch from 966cabe to eb40098 Compare October 25, 2019 07:02
@frol
Copy link
Collaborator Author

frol commented Oct 25, 2019

@vgrichina The tests pass on the current (already deployed) master. Staging should work fine as well, though it is down at the moment. The CI deployed nodes needs to be updated to include the chunk API.

@vgrichina vgrichina merged commit f4feff6 into master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants