Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare iOS Home Page prompt #367

Merged
merged 2 commits into from
Oct 3, 2023

Conversation

shelegdmitriy
Copy link
Contributor

Closes #604

@charleslavon
Copy link
Contributor

Hey @shelegdmitriy how do you suggest we test this? I've tried with bos-loader, but nothing is rendered and no errors are thrown at https://beta.near.org/test/widget/NearOrg.Notifications.HomeScreenAlert.

Also, this is the new modal and we'll need the logic which triggers this modal before showing the Enable Notifications modal. Does that already exists somewhere?

@shelegdmitriy
Copy link
Contributor Author

Also, this is the new modal and we'll need the logic which triggers this modal before showing the Enable Notifications modal. Does that already exists somewhere?

Yes, you're right. We have to trigger this modal from near-discovery repository as we do for NotificationAlert component. So far there is no such logic. But as far as this PR is merged I can use isIOS variable to create such functionality for iOS devices and there we can test it.

@shelegdmitriy
Copy link
Contributor Author

Actually we can make a pause with merging it and let me create such logic on near-discovery side and then make a loom video with an example. @charleslavon WDYT?

@charleslavon charleslavon merged commit 4634f8e into develop Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Push Notifications] Mobile iOS Set Home Icon screen is missing
2 participants