Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent NotificationAlert from appearing #685

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Prevent NotificationAlert from appearing #685

merged 2 commits into from
Oct 11, 2023

Conversation

shelegdmitriy
Copy link
Contributor

Closes #680

@shelegdmitriy shelegdmitriy self-assigned this Oct 10, 2023
@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 0:52am
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 0:52am

shelegdmitriy
shelegdmitriy commented Oct 10, 2023
View reviewed changes
src/pages/index.tsx Outdated Show resolved Hide resolved
@shelegdmitriy shelegdmitriy force-pushed the fix/notification-modal-flashing branch from 26e1b8b to dfda4a7 Compare October 10, 2023 16:10
@shelegdmitriy shelegdmitriy force-pushed the fix/notification-modal-flashing branch from dfda4a7 to 14e78d8 Compare October 10, 2023 16:13
@shelegdmitriy shelegdmitriy mentioned this pull request Oct 10, 2023
Merged
@calebjacob
Copy link
Collaborator

Unfortunately, I ended up having to refactor parts of this logic to fix a bug - so we're going to end up with a pretty ugly merge conflict. Let's wait until this is approved and merged first: #686

Sorry for the bad timing @shelegdmitriy

@shelegdmitriy
Copy link
Contributor Author

shelegdmitriy commented Oct 10, 2023 •
edited
Loading

Unfortunately, I ended up having to refactor parts of this logic to fix a bug - so we're going to end up with a pretty ugly merge conflict. Let's wait until this is approved and merged first: #686

Sorry for the bad timing @shelegdmitriy

Sure thing! I'll mark this one as draft then

@calebjacob I fixed the conflicts and this PR is ready for review

@shelegdmitriy shelegdmitriy marked this pull request as draft October 10, 2023 20:08
@shelegdmitriy shelegdmitriy force-pushed the fix/notification-modal-flashing branch from 14e78d8 to 032bd61 Compare October 10, 2023 20:51
@shelegdmitriy shelegdmitriy marked this pull request as ready for review October 10, 2023 20:51
calebjacob
calebjacob approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Let's see what Charles thinks about tracking the failure event.

@shelegdmitriy shelegdmitriy merged commit 3bd00fc into develop Oct 11, 2023
3 checks passed
@shelegdmitriy shelegdmitriy deleted the fix/notification-modal-flashing branch October 11, 2023 14:24
@github-actions github-actions bot mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charleslavon charleslavon charleslavon approved these changes

@calebjacob calebjacob calebjacob approved these changes

Assignees

@shelegdmitriy shelegdmitriy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications Opt-In Modal Appearing Incorrectly and Repeatedly
3 participants
@shelegdmitriy @calebjacob @charleslavon